Bug 246979 – AX: Improve Ref / RefPtr hygiene in WebAccessibilityObjectWrapperMac

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

rdar://100895546

[Radar WebKit Bug Importer]

<rdar://problem/101523132>

[Tyler Wilcock]

rdar://100895546

[Tyler Wilcock]

Created attachment 463208 [details]
Patch

[Darin Adler]

Comment on attachment 463208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463208&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:409
> +    RefPtr<AXCoreObject> backingObject = [self baseUpdateBackingStore];

Just RefPtr would do. No need to write out <AXCoreObject> each time.

[Tyler Wilcock]

(In reply to Darin Adler from comment #4)
> Comment on attachment 463208 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=463208&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:409
> > +    RefPtr<AXCoreObject> backingObject = [self baseUpdateBackingStore];
> 
> Just RefPtr would do. No need to write out <AXCoreObject> each time.
I originally had that, but template inference didn't seem able to figure it out:

OpenSource/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1115:12: error: no viable constructor or deduction guide for deduction of template arguments of 'RefPtr'
    RefPtr backingObject = self.updateObjectBackingStore;

[EWS]

Committed 255966@main (b036a036e04c): <https://commits.webkit.org/255966@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463208 [details].