Bug 244434 - [IFC][Integration] Do not paint ellipsis on non-visible block boxes.
Summary: [IFC][Integration] Do not paint ellipsis on non-visible block boxes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-08-27 10:57 PDT by zalan
Modified: 2022-08-28 16:36 PDT (History)
5 users (show)

See Also:

Attachments
[fast-cq]Patch (1.35 KB, patch)
2022-08-27 10:58 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-08-27 10:57:19 PDT 
ssia
Comment 1 zalan 2022-08-27 10:58:44 PDT 
Created attachment 461927 [details]
[fast-cq]Patch
Comment 2 Antti Koivisto 2022-08-28 09:46:13 PDT 
Comment on attachment 461927 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461927&action=review

> Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:105
> +    if (m_paintInfo.phase != PaintPhase::Foreground || root().style().visibility() != Visibility::Visible)

We should probably support some other PaintPhases (at least TextClip, not sure about the others)
Comment 3 zalan 2022-08-28 16:33:29 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 461927 [details]
> [fast-cq]Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=461927&action=review
> 
> > Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:105
> > +    if (m_paintInfo.phase != PaintPhase::Foreground || root().style().visibility() != Visibility::Visible)
> 
> We should probably support some other PaintPhases (at least TextClip, not
> sure about the others)
yeah
Comment 4 EWS 2022-08-28 16:35:57 PDT 
Committed 253888@main (682b15d4271a): <https://commits.webkit.org/253888@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461927 [details].
Comment 5 Radar WebKit Bug Importer 2022-08-28 16:36:16 PDT 
<rdar://problem/99255856>