Bug 24425 - Unify JSC/V8 History.idl
Summary: Unify JSC/V8 History.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Mike Belshe
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-06 09:32 PST by Mike Belshe
Modified: 2009-03-09 12:48 PDT (History)
1 user (show)

See Also:


Attachments
patch (1.17 KB, patch)
2009-03-06 09:34 PST, Mike Belshe
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Belshe 2009-03-06 09:32:10 PST
There is no difference in functionality between JSC and V8.

These IDL attributes enforce proper cross-domain security checking for the History object.  JSC implements this as part of its CustomGetOwnPropertySlot; v8 does this by using CheckDomainSecurity, allowing access specifically to back(), forward(), and go().

Both pass the layout tests.
Comment 1 Mike Belshe 2009-03-06 09:34:40 PST
Created attachment 28364 [details]
patch
Comment 2 Eric Seidel (no email) 2009-03-06 10:30:58 PST
Comment on attachment 28364 [details]
patch

Looks good to me.  Sam should see this pass by, but I expect he agrees with me. :)
Comment 3 Eric Seidel (no email) 2009-03-09 12:48:41 PDT
	M	WebCore/ChangeLog
	M	WebCore/page/History.idl
Committed r41534