Bug 242258 - [Make] Recognize feature flags in BUILD_WEBKIT_OPTIONS
Summary: [Make] Recognize feature flags in BUILD_WEBKIT_OPTIONS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-07-01 12:01 PDT by Elliott Williams
Modified: 2022-07-01 18:00 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-07-01 12:01:12 PDT 
build-webkit recognizes features defined in FeatureList.pm and passes corresponding build settings to Xcode. Make, despite having a BUILD_WEBKIT_OPTIONS setting for developers to override, does not parse out feature flag arguments. As a result, if you want to pass a feature flag to Make, you have to know what the corresponding build setting is. You also need to know that build-webkit defines the build setting as own name (i.e. ENABLE_PDFJS=ENABLE_PDFJS) and not YES.

We should fix this so that

    build-webkit --debug --pdfjs

and

    make debug BUILD_WEBKIT_OPTIONS=--pdfjs

pass the same settings.
Comment 1 Elliott Williams 2022-07-01 12:11:52 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2004
Comment 2 EWS 2022-07-01 17:59:03 PDT 
Committed 252082@main (97a065060b7d): <https://commits.webkit.org/252082@main>

Reviewed commits have been landed. Closing PR #2004 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-01 18:00:14 PDT 
<rdar://problem/96324453>