Bug 24184 - WebKit/Qt fails build disabling SVG
Summary: WebKit/Qt fails build disabling SVG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-25 23:35 PST by Charles Wei
Modified: 2009-02-26 14:43 PST (History)
1 user (show)

See Also:

Attachments
patch to fix the build failure of webkit/qt when SVG disabled (2.09 KB, patch)
2009-02-26 01:52 PST, Charles Wei 		staikos: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2009-02-25 23:35:38 PST 
WebKit for Qt failed build when turning SVG off (change WebCore.pro) .

CSSValueKeywords.in defines 

visiblePainted
visibleStroke
visibleFill

while the application expects them as visiblepainted , visiblestroke and visiblefill respectedly.  While SVG is enabled, this will be converted at build time with perl, while when SVG is disabled,  they are not , and that fails the build;

2nd failure of build failure when SVG is disabled is : 

FontPlatformData::FontPlatformData(float size, bool bold, bool oblique); is declared only when SVG is enabled;  while it's always defined disrearding SVG enabled or not .
Comment 1 Charles Wei 2009-02-26 01:52:45 PST 
Created attachment 28011 [details]
patch to fix the build failure of webkit/qt when SVG disabled
Comment 2 Adam Treat 2009-02-26 14:43:09 PST 
Landed with r41244.