Bug 241639 - [WebIDL] Optimize / rework maplike<> and setlike<> declarations
Summary: [WebIDL] Optimize / rework maplike<> and setlike<> declarations
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-15 11:33 PDT by Alexey Shvayka
Modified: 2022-06-22 11:34 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2022-06-15 11:33:17 PDT 
As Yusuke suggested in https://github.com/WebKit/WebKit/pull/1523#pullrequestreview-1006702442, Map / Set methods can be moved to JSGlobalObject's fields.
Also, we can go further and drop JSC::call and invoke C++ functions like mapProtoFuncValues directly, or even manipulate JSMap directly.

Sam suggested in https://github.com/WebKit/WebKit/pull/1523#issuecomment-1156653410 that we might not need backing Map / Set at all, as it merely duplicates data in most cases given DOM C++ code usually already had a HashMap or HashSet backing things.
Comment 1 Radar WebKit Bug Importer 2022-06-22 11:34:13 PDT 
<rdar://problem/95709260>