Bug 241635 - [GitHub] Style checker should be able to comment on the diff
Summary: [GitHub] Style checker should be able to comment on the diff
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency treegraph
 
Reported: 2022-06-15 09:04 PDT by Keith Miller
Modified: 2022-06-22 09:05 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2022-06-15 09:04:36 PDT
Right now there is the merge (not sure exactly what the name is) check for style. But reviewers still need to click on the details page to see if any are relevant. It could be useful to provide a button next to the details link that will have the style checker comment on the lines it thinks have issues. 

We may not want this all the time because it could become quite noisy, which happened back in the day on bugzilla. Thus, a button or some other user initiated trigger would be my recommendation.
Comment 1 Radar WebKit Bug Importer 2022-06-22 09:05:13 PDT
<rdar://problem/95695974>