Bug 241244 - Web Inspector: Layout overlay color swatches don't update saved color until popover is dismissed
Summary: Web Inspector: Layout overlay color swatches don't update saved color until p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-02 16:07 PDT by Patrick Angle
Modified: 2022-06-02 18:05 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2022-06-02 16:07:53 PDT
This causes a few issues:
1. DOM node badge colors don't update as you dynamically adjust the color for an overlay.
2. The new "sample color from screen" can be used without opening the popover for the color picker, which means these changes are never saved.
Comment 1 Radar WebKit Bug Importer 2022-06-02 16:44:17 PDT
<rdar://problem/94318762>
Comment 2 Patrick Angle 2022-06-02 16:51:41 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1256
Comment 3 EWS 2022-06-02 18:05:33 PDT
Committed r295164 (251248@main): <https://commits.webkit.org/251248@main>

Reviewed commits have been landed. Closing PR #1256 and removing active labels.