Bug 24117 - Fix QtWebKit build if SVG_FONTS are disabled
Summary: Fix QtWebKit build if SVG_FONTS are disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-23 20:59 PST by Laszlo Gombos
Modified: 2009-03-01 15:47 PST (History)
3 users (show)

See Also:


Attachments
Guard one of the constructor with ENABLE(SVG_FONTS) as in declaration (1.14 KB, patch)
2009-02-23 21:07 PST, Laszlo Gombos
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-02-23 20:59:20 PST
This is a regression introduced by changeset 39207. If SVG_FONTS are disabled one of the FontPlatformData constructors are not declared in the header file, but still implemented in the cpp file.

Patch will follow to guard the implementation of the function with ENABLE(SVG_FONTS), the same way as it is done for the function declaration.
Comment 1 Laszlo Gombos 2009-02-23 21:07:08 PST
Created attachment 27903 [details]
Guard one of the constructor with ENABLE(SVG_FONTS) as in declaration
Comment 2 Eric Seidel (no email) 2009-02-26 11:36:00 PST
Comment on attachment 27903 [details]
Guard one of the constructor with ENABLE(SVG_FONTS) as in declaration

I don't see this guarded in FontPlatformData.h  Why should it be guarded in the .cpp?
Comment 3 Laszlo Gombos 2009-02-26 11:53:50 PST
(In reply to comment #2)
> (From update of attachment 27903 [details] [review])
> I don't see this guarded in FontPlatformData.h  Why should it be guarded in the
> .cpp?

Eric,

This bug is specific to the Qt build. In the Qt build the mentioned contructor is guarded in the header. Please see 

http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/qt/FontPlatformData.h
Comment 4 Eric Seidel (no email) 2009-02-26 12:53:27 PST
Comment on attachment 27903 [details]
Guard one of the constructor with ENABLE(SVG_FONTS) as in declaration

Pardon my confusion.  I thought FontPlatformData.h was a shared header, but now I realize that's silly. ;)
Comment 5 David Levin 2009-03-01 15:47:11 PST
This was fixed with r41244.