Bug 240490 - git webkit setup opens a GitHub web page without warning
Summary: git webkit setup opens a GitHub web page without warning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-05-16 16:27 PDT by Alexey Proskuryakov
Modified: 2022-05-23 11:54 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2022-05-16 16:27:56 PDT 
The GitHub webpage for generating a personal access token pops up without a warning. Even as I switch back to Terminal, there isn't really an explanation of what is going to happen:

Authentication required to use GitHub's API
Provide github.com username and access token to create and update pull requests
Username: aproskuryakov
Token: 

I would expect something like:

git webkit needs an access token to use GitHub API. Please press Enter to open github.com in your Web browser, and click "Generate Token" at the bottom of the page.
:
Comment 1 Radar WebKit Bug Importer 2022-05-18 13:08:30 PDT 
<rdar://problem/93522009>
Comment 2 Jonathan Bedard 2022-05-20 16:06:18 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/867
Comment 3 EWS 2022-05-23 11:54:15 PDT 
Committed r294661 (250881@main): <https://commits.webkit.org/250881@main>

Reviewed commits have been landed. Closing PR #867 and removing active labels.