Bug 240108 - [WK2][Cocoa] Remove use of CVPixelBufferConformer from WebContent process in MediaPlayerPrivateRemote::nativeImageForCurrentTime()
Summary: [WK2][Cocoa] Remove use of CVPixelBufferConformer from WebContent process in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-04 21:35 PDT by Jer Noble
Modified: 2022-05-05 09:14 PDT (History)
8 users (show)

See Also:


Attachments
Patch (13.50 KB, patch)
2022-05-04 21:41 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2022-05-04 21:35:09 PDT
[WK2][Cocoa] Remove use of CVPixelBufferConformer from WebContent process in MediaPlayerPrivateRemote::nativeImageForCurrentTime()
Comment 1 Radar WebKit Bug Importer 2022-05-04 21:35:34 PDT
<rdar://problem/92773611>
Comment 2 Jer Noble 2022-05-04 21:41:30 PDT
Created attachment 458850 [details]
Patch
Comment 3 youenn fablet 2022-05-05 01:31:19 PDT
Comment on attachment 458850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458850&action=review

> Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:66
>      if (!connection().sendSync(Messages::RemoteMediaPlayerProxy::NativeImageForCurrentTime(), Messages::RemoteMediaPlayerProxy::NativeImageForCurrentTime::Reply(sendRight, colorSpace), m_id))

This sync IPC is getting a mach send right to create an IOSurface.
This will probably fail if IOKit is blocked.
Comment 4 Jer Noble 2022-05-05 08:18:27 PDT
(In reply to youenn fablet from comment #3)
> Comment on attachment 458850 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458850&action=review
> 
> > Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:66
> >      if (!connection().sendSync(Messages::RemoteMediaPlayerProxy::NativeImageForCurrentTime(), Messages::RemoteMediaPlayerProxy::NativeImageForCurrentTime::Reply(sendRight, colorSpace), m_id))
> 
> This sync IPC is getting a mach send right to create an IOSurface.
> This will probably fail if IOKit is blocked.

We'll have to deal with that in another patch.
Comment 5 EWS 2022-05-05 09:14:20 PDT
Committed r293839 (250312@main): <https://commits.webkit.org/250312@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458850 [details].