Bug 240085 - [git-webkit] Verify forks after creation
Summary: [git-webkit] Verify forks after creation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-04 15:18 PDT by Jonathan Bedard
Modified: 2022-05-09 13:38 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-05-04 15:18:27 PDT
Forking a repo in GitHub is not instant, and `git-webkit setup` may fail if creation of a private fork takes longer than we expect it to.

First, we should have a better error message in this case. We should also be a bit more patient, GitHub advertises that forking may take a minute or two.
Comment 1 Radar WebKit Bug Importer 2022-05-09 12:13:28 PDT
<rdar://problem/92978491>
Comment 2 Jonathan Bedard 2022-05-09 12:15:15 PDT
Pull request: https://github.com/WebKit/WebKit/pull/568
Comment 3 Jonathan Bedard 2022-05-09 12:42:04 PDT
Changing the title of this bug slightly because there is a very similar problem involving private forks coming from repos with the same name.
Comment 4 Jonathan Bedard 2022-05-09 13:38:02 PDT
Landed https://commits.webkit.org/250423@main