Bug 239744 - [iOS] Infinite recursion at -[WKFullScreenWindowController _exitFullscreenImmediately]
Summary: [iOS] Infinite recursion at -[WKFullScreenWindowController _exitFullscreenImm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
: 239071 239076 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-04-25 15:56 PDT by Jer Noble
Modified: 2022-05-06 12:51 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.43 KB, patch)
2022-04-25 16:30 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (9.88 KB, patch)
2022-05-05 10:14 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2022-04-25 15:56:24 PDT 
[iOS] Infinite recursion at -[WKFullScreenWindowController _exitFullscreenImmediately]
Comment 1 Jer Noble 2022-04-25 15:56:39 PDT 
<rdar://74201964>
Comment 2 Jer Noble 2022-04-25 16:30:53 PDT 
Created attachment 458309 [details]
Patch
Comment 3 Eric Carlson 2022-04-25 21:10:20 PDT 
Comment on attachment 458309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458309&action=review

> Source/WebCore/dom/FullscreenManager.cpp:116
> +    INFO_LOG(LOGIDENTIFIER);

This happens infrequently enough I think it might as well use ALWAYS_LOG.

> Source/WebCore/dom/FullscreenManager.cpp:293
> +    INFO_LOG(LOGIDENTIFIER);

Ditto

> Source/WebCore/dom/FullscreenManager.cpp:640
> +    INFO_LOG(LOGIDENTIFIER, flag);

Ditto

> Source/WebCore/dom/FullscreenManager.cpp:658
> +    INFO_LOG(LOGIDENTIFIER, flag);

Ditto
Comment 4 Jer Noble 2022-05-05 10:14:57 PDT 
Created attachment 458885 [details]
Patch for landing
Comment 5 EWS 2022-05-06 09:10:18 PDT 
Committed r293894 (250352@main): <https://commits.webkit.org/250352@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458885 [details].
Comment 6 Ali Juma 2022-05-06 12:51:31 PDT 
*** Bug 239076 has been marked as a duplicate of this bug. ***
Comment 7 Ali Juma 2022-05-06 12:51:48 PDT 
*** Bug 239071 has been marked as a duplicate of this bug. ***