Bug 239421 - Fix a deadlock in VMTraps.
Summary: Fix a deadlock in VMTraps.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-16 10:36 PDT by Mark Lam
Modified: 2022-04-16 21:23 PDT (History)
6 users (show)

See Also:


Attachments
[fast-cq] proposed patch. (3.80 KB, patch)
2022-04-16 11:11 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-04-16 10:36:45 PDT
There is an inversion in lock ordering between VMTraps and the Sampling Profiler.
Comment 1 Radar WebKit Bug Importer 2022-04-16 10:37:08 PDT
<rdar://problem/91851592>
Comment 2 Mark Lam 2022-04-16 11:11:43 PDT
Created attachment 457751 [details]
[fast-cq] proposed patch.
Comment 3 Michael Saboff 2022-04-16 14:08:53 PDT
Comment on attachment 457751 [details]
[fast-cq] proposed patch.

r=me
Comment 4 Mark Lam 2022-04-16 21:20:41 PDT
Comment on attachment 457751 [details]
[fast-cq] proposed patch.

Thanks for the review.  Landing now.
Comment 5 EWS 2022-04-16 21:23:30 PDT
Committed r292946 (249711@main): <https://commits.webkit.org/249711@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457751 [details].