Bug 239038 - [GTK][WPE] Provide WK2 IPC encoding, decoding methods for the DMABufObject type
Summary: [GTK][WPE] Provide WK2 IPC encoding, decoding methods for the DMABufObject type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on: 238740
Blocks: DMA-BUF
  Show dependency tree / graph
 
Reported: 2022-04-09 13:25 PDT by Zan Dobersek
Modified: 2022-04-14 11:03 PDT (History)
2 users (show)

See Also:

Attachments
WIP patch (4.09 KB, patch)
2022-04-09 13:25 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (4.62 KB, patch)
2022-04-10 23:08 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (4.85 KB, patch)
2022-04-12 09:15 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2022-04-09 13:25:22 PDT 
[GTK][WPE] Provide WK2 IPC encoding, decoding methods for the DMABufObject type
Comment 1 Zan Dobersek 2022-04-09 13:25:44 PDT 
Created attachment 457179 [details]
WIP patch
Comment 2 Zan Dobersek 2022-04-10 23:08:32 PDT 
Created attachment 457232 [details]
Patch
Comment 3 Zan Dobersek 2022-04-12 09:15:10 PDT 
Created attachment 457335 [details]
Patch

Added missing <optional> include.
Comment 4 Adrian Perez 2022-04-13 09:08:22 PDT 
Comment on attachment 457335 [details]
Patch

Patch LGTM, modulo fixing the style checker issues before landing :)
Comment 5 Zan Dobersek 2022-04-14 07:11:08 PDT 
(In reply to Adrian Perez from comment #4)
> Comment on attachment 457335 [details]
> Patch
> 
> Patch LGTM, modulo fixing the style checker issues before landing :)

Can't, the style checker doesn't handle ref qualifiers.
Comment 6 Zan Dobersek 2022-04-14 07:13:51 PDT 
Comment on attachment 457335 [details]
Patch

Clearing flags on attachment: 457335

Committed r292864 (249635@trunk): <https://commits.webkit.org/249635@trunk>
Comment 7 Zan Dobersek 2022-04-14 07:13:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2022-04-14 07:14:18 PDT 
<rdar://problem/91751419>
Comment 9 Adrian Perez 2022-04-14 11:03:15 PDT 
(In reply to Zan Dobersek from comment #5)
> (In reply to Adrian Perez from comment #4)
> > Comment on attachment 457335 [details]
> > Patch
> > 
> > Patch LGTM, modulo fixing the style checker issues before landing :)
> 
> Can't, the style checker doesn't handle ref qualifiers.

Ah, pity.