Bug 238692 - Fix the WebGPU-less build
Summary: Fix the WebGPU-less build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-01 18:56 PDT by Tim Horton
Modified: 2022-04-01 19:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.55 KB, patch)
2022-04-01 18:57 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (1.69 KB, patch)
2022-04-01 18:59 PDT, Tim Horton 		mmaxfield: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2022-04-01 18:56:47 PDT 
Fix the WebGPU-less build
Comment 1 Tim Horton 2022-04-01 18:57:02 PDT 
Created attachment 456425 [details]
Patch
Comment 2 Myles C. Maxfield 2022-04-01 18:58:20 PDT 
Comment on attachment 456425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456425&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:158
> -WK_NETWORK_EXTENSION_LD_FLAGS = $(WK_NETWORK_EXTENSION_LD_FLAGS_$(WK_PLATFORM_NAME));
> -WK_NETWORK_EXTENSION_LD_FLAGS_iphoneos = -framework NetworkExtension;
> -WK_NETWORK_EXTENSION_LD_FLAGS_iphonesimulator = -framework NetworkExtension;
> -WK_NETWORK_EXTENSION_LD_FLAGS_watchos = -framework NetworkExtension;
> -WK_NETWORK_EXTENSION_LD_FLAGS_watchsimulator = -framework NetworkExtension;
> -WK_NETWORK_EXTENSION_LD_FLAGS_maccatalyst = -framework NetworkExtension;
> -WK_NETWORK_EXTENSION_LD_FLAGS_macosx = -weak_framework NetworkExtension;
> +WK_NETWORK_EXTENSION_LDFLAGS = $(WK_NETWORK_EXTENSION_LDFLAGS_$(WK_PLATFORM_NAME));
> +WK_NETWORK_EXTENSION_LDFLAGS_iphoneos = -framework NetworkExtension;
> +WK_NETWORK_EXTENSION_LDFLAGS_iphonesimulator = -framework NetworkExtension;
> +WK_NETWORK_EXTENSION_LDFLAGS_watchos = -framework NetworkExtension;
> +WK_NETWORK_EXTENSION_LDFLAGS_watchsimulator = -framework NetworkExtension;
> +WK_NETWORK_EXTENSION_LDFLAGS_maccatalyst = -framework NetworkExtension;
> +WK_NETWORK_EXTENSION_LDFLAGS_macosx = -weak_framework NetworkExtension;

Please don't do this in this patch. Please do this in another patch.
Comment 3 Tim Horton 2022-04-01 18:59:37 PDT 
Created attachment 456426 [details]
Patch
Comment 4 Myles C. Maxfield 2022-04-01 19:01:14 PDT 
Comment on attachment 456426 [details]
Patch

r=mews
Comment 5 Tim Horton 2022-04-01 19:01:46 PDT 
(In reply to Myles C. Maxfield from comment #2)
> Comment on attachment 456425 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456425&action=review
> 
> > Source/WebCore/Configurations/WebCore.xcconfig:158
> > -WK_NETWORK_EXTENSION_LD_FLAGS = $(WK_NETWORK_EXTENSION_LD_FLAGS_$(WK_PLATFORM_NAME));
> > -WK_NETWORK_EXTENSION_LD_FLAGS_iphoneos = -framework NetworkExtension;
> > -WK_NETWORK_EXTENSION_LD_FLAGS_iphonesimulator = -framework NetworkExtension;
> > -WK_NETWORK_EXTENSION_LD_FLAGS_watchos = -framework NetworkExtension;
> > -WK_NETWORK_EXTENSION_LD_FLAGS_watchsimulator = -framework NetworkExtension;
> > -WK_NETWORK_EXTENSION_LD_FLAGS_maccatalyst = -framework NetworkExtension;
> > -WK_NETWORK_EXTENSION_LD_FLAGS_macosx = -weak_framework NetworkExtension;
> > +WK_NETWORK_EXTENSION_LDFLAGS = $(WK_NETWORK_EXTENSION_LDFLAGS_$(WK_PLATFORM_NAME));
> > +WK_NETWORK_EXTENSION_LDFLAGS_iphoneos = -framework NetworkExtension;
> > +WK_NETWORK_EXTENSION_LDFLAGS_iphonesimulator = -framework NetworkExtension;
> > +WK_NETWORK_EXTENSION_LDFLAGS_watchos = -framework NetworkExtension;
> > +WK_NETWORK_EXTENSION_LDFLAGS_watchsimulator = -framework NetworkExtension;
> > +WK_NETWORK_EXTENSION_LDFLAGS_maccatalyst = -framework NetworkExtension;
> > +WK_NETWORK_EXTENSION_LDFLAGS_macosx = -weak_framework NetworkExtension;
> 
> Please don't do this in this patch. Please do this in another patch.

ap got me in a drive-by-fix mood in bug 238655, but yes, you're right, I've posted a version with that reverted.
Comment 6 Tim Horton 2022-04-01 19:15:20 PDT 
https://trac.webkit.org/changeset/292253/webkit
Comment 7 Radar WebKit Bug Importer 2022-04-01 19:16:17 PDT 
<rdar://problem/91192100>