RESOLVED FIXED Bug 238692
Fix the WebGPU-less build 
https://bugs.webkit.org/show_bug.cgi?id=238692
Summary Fix the WebGPU-less build
Tim Horton
Reported 2022-04-01 18:56:47 PDT
Fix the WebGPU-less build
Attachments
Patch (5.55 KB, patch)
2022-04-01 18:57 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (1.69 KB, patch)
2022-04-01 18:59 PDT, Tim Horton 		mmaxfield: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2022-04-01 18:57:02 PDT
Created attachment 456425 [details] Patch
Myles C. Maxfield
Comment 2 2022-04-01 18:58:20 PDT
Comment on attachment 456425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456425&action=review > Source/WebCore/Configurations/WebCore.xcconfig:158 > -WK_NETWORK_EXTENSION_LD_FLAGS = $(WK_NETWORK_EXTENSION_LD_FLAGS_$(WK_PLATFORM_NAME)); > -WK_NETWORK_EXTENSION_LD_FLAGS_iphoneos = -framework NetworkExtension; > -WK_NETWORK_EXTENSION_LD_FLAGS_iphonesimulator = -framework NetworkExtension; > -WK_NETWORK_EXTENSION_LD_FLAGS_watchos = -framework NetworkExtension; > -WK_NETWORK_EXTENSION_LD_FLAGS_watchsimulator = -framework NetworkExtension; > -WK_NETWORK_EXTENSION_LD_FLAGS_maccatalyst = -framework NetworkExtension; > -WK_NETWORK_EXTENSION_LD_FLAGS_macosx = -weak_framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS = $(WK_NETWORK_EXTENSION_LDFLAGS_$(WK_PLATFORM_NAME)); > +WK_NETWORK_EXTENSION_LDFLAGS_iphoneos = -framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS_iphonesimulator = -framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS_watchos = -framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS_watchsimulator = -framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS_maccatalyst = -framework NetworkExtension; > +WK_NETWORK_EXTENSION_LDFLAGS_macosx = -weak_framework NetworkExtension; Please don't do this in this patch. Please do this in another patch.
Tim Horton
Comment 3 2022-04-01 18:59:37 PDT
Created attachment 456426 [details] Patch
Myles C. Maxfield
Comment 4 2022-04-01 19:01:14 PDT
Comment on attachment 456426 [details] Patch r=mews
Tim Horton
Comment 5 2022-04-01 19:01:46 PDT
(In reply to Myles C. Maxfield from comment #2) > Comment on attachment 456425 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456425&action=review > > > Source/WebCore/Configurations/WebCore.xcconfig:158 > > -WK_NETWORK_EXTENSION_LD_FLAGS = $(WK_NETWORK_EXTENSION_LD_FLAGS_$(WK_PLATFORM_NAME)); > > -WK_NETWORK_EXTENSION_LD_FLAGS_iphoneos = -framework NetworkExtension; > > -WK_NETWORK_EXTENSION_LD_FLAGS_iphonesimulator = -framework NetworkExtension; > > -WK_NETWORK_EXTENSION_LD_FLAGS_watchos = -framework NetworkExtension; > > -WK_NETWORK_EXTENSION_LD_FLAGS_watchsimulator = -framework NetworkExtension; > > -WK_NETWORK_EXTENSION_LD_FLAGS_maccatalyst = -framework NetworkExtension; > > -WK_NETWORK_EXTENSION_LD_FLAGS_macosx = -weak_framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS = $(WK_NETWORK_EXTENSION_LDFLAGS_$(WK_PLATFORM_NAME)); > > +WK_NETWORK_EXTENSION_LDFLAGS_iphoneos = -framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS_iphonesimulator = -framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS_watchos = -framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS_watchsimulator = -framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS_maccatalyst = -framework NetworkExtension; > > +WK_NETWORK_EXTENSION_LDFLAGS_macosx = -weak_framework NetworkExtension; > > Please don't do this in this patch. Please do this in another patch. ap got me in a drive-by-fix mood in bug 238655, but yes, you're right, I've posted a version with that reverted.
Tim Horton
Comment 6 2022-04-01 19:15:20 PDT
https://trac.webkit.org/changeset/292253/webkit
Radar WebKit Bug Importer
Comment 7 2022-04-01 19:16:17 PDT
<rdar://problem/91192100>
Note You need to log in before you can comment on or make changes to this bug.