Bug 238382 – [PlayStation] Provide defaults in WebsiteDataStore

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Don Olmstead]

Everything is currently returning empty strings.

[Don Olmstead]

Created attachment 455775 [details]
WIP Patch

[Stephan Szabo]

Comment on attachment 455775 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455775&action=review

> Source/WebKit/UIProcess/WebsiteData/playstation/WebsiteDataStorePlayStation.cpp:109
> +    return FileSystem::pathByAppendingComponent(FileSystem::userCacheDirectory(), directoryName);

Is this correct for cases where we're not in the USE(WPE_BACKEND_PLAYSTATION)? It seems like you'd get whatever the result of appending directoryName to an empty string was, which doesn't seem like it'd retain the previous behavior.

[Stephan Szabo]

Comment on attachment 455775 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455775&action=review

> Source/WebKit/UIProcess/WebsiteData/playstation/WebsiteDataStorePlayStation.cpp:114
> +    return FileSystem::pathByAppendingComponent(FileSystem::userDataDirectory(), directoryName);

As with cacheDirectoryFileSystemRepresentation, is this going to do what we want in cases userDataDirectory returns an empty string?

[Don Olmstead]

Created attachment 455777 [details]
WIP Patch

[Don Olmstead]

This should address the issues mentioned.

Going to work on upstreaming libwpe and adding to our WPE backend before marking it for review.

[Don Olmstead]

Created attachment 455806 [details]
WIP Patch

[Don Olmstead]

Created attachment 456042 [details]
WIP Patch

[Radar WebKit Bug Importer]

<rdar://problem/91167092>

[Don Olmstead]

Pull request: https://github.com/WebKit/WebKit/pull/4931

[EWS]

Committed 255192@main (cbc7d03e34bb): <https://commits.webkit.org/255192@main>

Reviewed commits have been landed. Closing PR #4931 and removing active labels.