WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
237634
Add myself (Gabriel Nava Marino) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237634
Summary
Add myself (Gabriel Nava Marino) to contributors.json
Gabriel Nava Marino
Reported
2022-03-08 19:20:10 PST
...
Attachments
Patch
(1.10 KB, patch)
2022-03-08 19:31 PST
,
Gabriel Nava Marino
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.10 KB, patch)
2022-03-14 17:10 PDT
,
Gabriel Nava Marino
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Gabriel Nava Marino
Comment 1
2022-03-08 19:31:59 PST
Created
attachment 454187
[details]
Patch
EWS
Comment 2
2022-03-09 13:48:15 PST
gnavamarino@apple.com
does not have committer permissions according to
https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json
. Rejecting
attachment 454187
[details]
from commit queue.
Chris Dumez
Comment 3
2022-03-09 13:49:03 PST
Comment on
attachment 454187
[details]
Patch You need to commit the patch manually. You cannot use the commit queue to land a change stating that you are a committer.
Tim Nguyen (:ntim)
Comment 4
2022-03-14 16:32:13 PDT
Comment on
attachment 454187
[details]
Patch What Chris said. Use `webkit-patch land`.
Gabriel Nava Marino
Comment 5
2022-03-14 17:10:35 PDT
Created
attachment 454638
[details]
Patch for landing
EWS
Comment 6
2022-03-14 17:10:42 PDT
gnavamarino@apple.com
does not have committer permissions according to
https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json
. Rejecting
attachment 454638
[details]
from commit queue.
Gabriel Nava Marino
Comment 7
2022-03-14 17:13:18 PDT
(In reply to Tim Nguyen (:ntim) from
comment #4
)
> Comment on
attachment 454187
[details]
> Patch > > What Chris said. Use `webkit-patch land`.
I was having some issues with svn, but I think I've resolved them. I will be doing this now.
Gabriel Nava Marino
Comment 8
2022-03-14 17:18:03 PDT
Committed
r291256
(
248408@trunk
): <
https://commits.webkit.org/248408@trunk
>
Radar WebKit Bug Importer
Comment 9
2022-03-14 17:19:18 PDT
<
rdar://problem/90278866
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug