WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
237495
Replace IntRectExtent with RectEdges<int>
https://bugs.webkit.org/show_bug.cgi?id=237495
Summary
Replace IntRectExtent with RectEdges<int>
Simon Fraser (smfr)
Reported
2022-03-04 20:53:17 PST
Replace IntRectExtent with RectEdges<int>
Attachments
Patch
(19.08 KB, patch)
2022-03-04 20:56 PST
,
Simon Fraser (smfr)
sam
: review+
Details
Formatted Diff
Diff
Patch
(19.23 KB, patch)
2022-03-05 11:23 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2022-03-04 20:56:13 PST
Created
attachment 453895
[details]
Patch
Sam Weinig
Comment 2
2022-03-05 08:51:21 PST
Comment on
attachment 453895
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=453895&action=review
> Source/WebCore/platform/RectEdges.h:104 > +template<typename T> > +inline RectEdges<T>& operator+=(RectEdges<T>& a, const RectEdges<T>& b)
I'd encourage you to write both += and + (you can usually have one call the other).
Simon Fraser (smfr)
Comment 3
2022-03-05 11:23:19 PST
Created
attachment 453915
[details]
Patch
EWS
Comment 4
2022-03-05 22:51:29 PST
Committed
r290872
(
248103@main
): <
https://commits.webkit.org/248103@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 453915
[details]
.
Radar WebKit Bug Importer
Comment 5
2022-03-05 22:52:21 PST
<
rdar://problem/89868237
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug