Bug 237495 - Replace IntRectExtent with RectEdges<int>
Summary: Replace IntRectExtent with RectEdges<int>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-04 20:53 PST by Simon Fraser (smfr)
Modified: 2022-03-05 22:52 PST (History)
18 users (show)

See Also:

Attachments
Patch (19.08 KB, patch)
2022-03-04 20:56 PST, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
Patch (19.23 KB, patch)
2022-03-05 11:23 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-03-04 20:53:17 PST 
Replace IntRectExtent with RectEdges<int>
Comment 1 Simon Fraser (smfr) 2022-03-04 20:56:13 PST 
Created attachment 453895 [details]
Patch
Comment 2 Sam Weinig 2022-03-05 08:51:21 PST 
Comment on attachment 453895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453895&action=review

> Source/WebCore/platform/RectEdges.h:104
> +template<typename T>
> +inline RectEdges<T>& operator+=(RectEdges<T>& a, const RectEdges<T>& b)

I'd encourage you to write both += and + (you can usually have one call the other).
Comment 3 Simon Fraser (smfr) 2022-03-05 11:23:19 PST 
Created attachment 453915 [details]
Patch
Comment 4 EWS 2022-03-05 22:51:29 PST 
Committed r290872 (248103@main): <https://commits.webkit.org/248103@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453915 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-05 22:52:21 PST 
<rdar://problem/89868237>