Bug 237200 - Ensure RemoteMediaPlayerProxy sets its resource owner to pixel buffers created by its player
Summary: Ensure RemoteMediaPlayerProxy sets its resource owner to pixel buffers create...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-25 04:58 PST by youenn fablet
Modified: 2022-02-28 03:15 PST (History)
7 users (show)

See Also:

Attachments
Patch (11.79 KB, patch)
2022-02-25 05:02 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (12.64 KB, patch)
2022-02-27 23:21 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-02-25 04:58:26 PST 
Ensure RemoteMediaPlayerProxy sets its resource owner to pixel buffers created by its player
Comment 1 youenn fablet 2022-02-25 05:02:38 PST 
Created attachment 453200 [details]
Patch
Comment 2 Eric Carlson 2022-02-25 08:50:15 PST 
Comment on attachment 453200 [details]
Patch

It might be worth adding the same logic to MediaPlayerPrivateMediaStreamAVFObjC as well, in case we move it to the GPU Process at some point.
Comment 3 youenn fablet 2022-02-27 23:15:50 PST 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 453200 [details]
> Patch
> 
> It might be worth adding the same logic to
> MediaPlayerPrivateMediaStreamAVFObjC as well, in case we move it to the GPU
> Process at some point.

I'll add an ASSERT in MediaPlayerPrivateMediaStreamAVFObjC to make it clear it should be implemented if we ever do that.
Comment 4 youenn fablet 2022-02-27 23:21:38 PST 
Created attachment 453370 [details]
Patch for landing
Comment 5 EWS 2022-02-28 02:05:08 PST 
Committed r290590 (247868@main): <https://commits.webkit.org/247868@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453370 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-28 02:06:18 PST 
<rdar://problem/89548310>