Bug 237016 - Enabled accelerated drawing on Mac test bots
Summary: Enabled accelerated drawing on Mac test bots
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-21 20:49 PST by Jon Lee
Modified: 2022-02-24 01:27 PST (History)
9 users (show)

See Also:

Attachments
Patch for EWS (1.32 KB, patch)
2022-02-21 20:53 PST, Jon Lee 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.22 KB, patch)
2022-02-22 09:31 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (67.74 KB, patch)
2022-02-22 23:21 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (76.53 KB, patch)
2022-02-23 16:53 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (86.27 KB, patch)
2022-02-23 23:09 PST, Jon Lee 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2022-02-21 20:49:00 PST 
.
Comment 1 Jon Lee 2022-02-21 20:49:39 PST 
rdar://70104226
Comment 2 Jon Lee 2022-02-21 20:53:37 PST 
Created attachment 452820 [details]
Patch for EWS
Comment 3 Jon Lee 2022-02-22 09:31:27 PST 
Created attachment 452877 [details]
Patch
Comment 4 Darin Adler 2022-02-22 09:47:26 PST 
Comment on attachment 452877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452877&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:245
> -        self._interrupt_if_at_failure_limits(self._current_run_results)
> +        #self._interrupt_if_at_failure_limits(self._current_run_results)

?
Comment 5 Jon Lee 2022-02-22 12:26:32 PST 
Comment on attachment 452877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452877&action=review

>> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:245
>> +        #self._interrupt_if_at_failure_limits(self._current_run_results)
> 
> ?

Sorry, didn't mean to r? this. I wanted to see what failure Mac EWS reported.
Comment 6 Jon Lee 2022-02-22 23:21:43 PST 
Created attachment 452942 [details]
Patch
Comment 7 EWS Watchlist 2022-02-22 23:26:35 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 8 Jon Lee 2022-02-23 16:53:44 PST 
Created attachment 453056 [details]
Patch
Comment 9 Jon Lee 2022-02-23 23:09:24 PST 
Created attachment 453077 [details]
Patch