Bug 23701 - wxWebKit build script gets incomplete arguments
Summary: wxWebKit build script gets incomplete arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-02 20:40 PST by Diggilin
Modified: 2009-02-03 16:39 PST (History)
0 users

See Also:


Attachments
Fixes bug (2.47 KB, patch)
2009-02-02 20:44 PST, Diggilin
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diggilin 2009-02-02 20:40:12 PST
Not all needed arguments are passed on to the wxWebKit build script. The method of passing arguments is also not very intuitive.
Comment 1 Diggilin 2009-02-02 20:44:39 PST
Created attachment 27275 [details]
Fixes bug

In order to fix this bug, a slight adjustment was made to the checkForArgumentAndRemoveFromARGV() function in webkitdirs.pm. See changelog for details.
Comment 2 Darin Adler 2009-02-03 09:29:27 PST
Comment on attachment 27275 [details]
Fixes bug

Looks fine, r=me
Comment 3 Kevin Ollivier 2009-02-03 16:39:43 PST
Landed in r40556, thanks!