RESOLVED FIXED 236899
[WebGPU] Tracer bullet part 6: Give a RunLoop to Instance 
https://bugs.webkit.org/show_bug.cgi?id=236899
Summary [WebGPU] Tracer bullet part 6: Give a RunLoop to Instance
Myles C. Maxfield
Reported 2022-02-19 16:39:28 PST
The shared header has a function, wgpuInstanceProcessEvents(), which is supposed to synchronously call all outstanding callbacks. A natural way to do this is to hook this up to [NSRunLoop runMode:beforeDate:].
Attachments
Patch (4.17 KB, patch)
2022-02-19 16:40 PST, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-02-19 16:40:46 PST
Created attachment 452663 [details] Patch
Dean Jackson
Comment 2 2022-02-21 09:26:49 PST
Comment on attachment 452663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452663&action=review > Source/WebGPU/ChangeLog:10 > + The shared header has a function, wgpuInstanceProcessEvents(), which is supposed > + to synchronously call all outstanding callbacks. A natural way to do this is to > + hook this up to [NSRunLoop runMode:beforeDate:]. What's the layering between WebGPU and Foundation? How would a non-Apple port do this?
Myles C. Maxfield
Comment 3 2022-02-21 11:46:49 PST
Comment on attachment 452663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452663&action=review >> Source/WebGPU/ChangeLog:10 >> + hook this up to [NSRunLoop runMode:beforeDate:]. > > What's the layering between WebGPU and Foundation? How would a non-Apple port do this? Non-Apple ports wouldn't use WebGPU.framework at all. They would use Dawn or wgpu. So the layering is just "Foundation is below WebGPU.framework."
Myles C. Maxfield
Comment 4 2022-02-21 11:58:57 PST
Committed r290258 (?): <https://commits.webkit.org/r290258>
Radar WebKit Bug Importer
Comment 5 2022-02-21 11:59:21 PST
<rdar://problem/89249380>
Note You need to log in before you can comment on or make changes to this bug.