Bug 236828 – [custom-effect] Animations associated with a custom effect should appear in document.getAnimations() result

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

[custom-effect] Animations associated with a custom effect should appear in document.getAnimations() result

[Antoine Quint]

Created attachment 452492 [details]
Patch

[Dean Jackson]

Comment on attachment 452492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452492&action=review

> LayoutTests/ChangeLog:9
> +        * webanimations/custom-effect/custom-effect-get-animations-expected.txt: Added.
> +        * webanimations/custom-effect/custom-effect-get-animations.html: Added.

Shouldn't this be in a WPT directory so we can contribute it back? What will track that effort?

[Antoine Quint]

(In reply to Dean Jackson from comment #2)
> Comment on attachment 452492 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452492&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        * webanimations/custom-effect/custom-effect-get-animations-expected.txt: Added.
> > +        * webanimations/custom-effect/custom-effect-get-animations.html: Added.
> 
> Shouldn't this be in a WPT directory so we can contribute it back? What will
> track that effort?

I'm writing all of those custom-effect tests with testharness so we may contribute them back, but I don't think we should upstream them until there are approved pull requests for the changes suggested.

[Antoine Quint]

Committed r290122 (?): <https://commits.webkit.org/r290122>

[Radar WebKit Bug Importer]

<rdar://problem/89144597>