Bug 236772 - [GTK][WPE] Don't use ANGLE's GBM-based display
Summary: [GTK][WPE] Don't use ANGLE's GBM-based display
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-17 04:39 PST by Zan Dobersek
Modified: 2022-02-18 00:50 PST (History)
13 users (show)

See Also:

Attachments
Patch (5.77 KB, patch)
2022-02-17 04:55 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (5.81 KB, patch)
2022-02-17 23:11 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2022-02-17 04:39:36 PST 
[GTK][WPE] Don't use ANGLE's GBM-based display
Comment 1 Zan Dobersek 2022-02-17 04:55:47 PST 
Created attachment 452351 [details]
Patch
Comment 2 EWS Watchlist 2022-02-17 04:57:24 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Alejandro G. Castro 2022-02-17 10:50:25 PST 
Comment on attachment 452351 [details]
Patch

Great patch! It seems there is some indentation issue
Comment 4 Zan Dobersek (Reviews) 2022-02-17 22:57:15 PST 
No, it's a case of indentation not properly covered in the style script.
Comment 5 EWS 2022-02-17 22:58:30 PST 
Tools/Scripts/svn-apply failed to apply attachment 452351 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Zan Dobersek 2022-02-17 23:01:41 PST 
OK then.
Comment 7 Zan Dobersek 2022-02-17 23:11:42 PST 
Created attachment 452487 [details]
Patch for landing
Comment 8 EWS 2022-02-18 00:49:40 PST 
Committed r290118 (247462@main): <https://commits.webkit.org/247462@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452487 [details].
Comment 9 Radar WebKit Bug Importer 2022-02-18 00:50:16 PST 
<rdar://problem/89133728>