RESOLVED FIXED 236751
[Cocoa] Link WebCore with WebGPU.framework 🎉 
https://bugs.webkit.org/show_bug.cgi?id=236751
Summary [Cocoa] Link WebCore with WebGPU.framework 🎉
Myles C. Maxfield
Reported 2022-02-16 21:43:39 PST
[Cocoa] Link WebCore with WebGPU.framework 🎉
Attachments
Patch (2.80 KB, patch)
2022-02-16 21:46 PST, Myles C. Maxfield 		dino: review+
mmaxfield: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (109.11 KB, patch)
2022-03-29 19:47 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-02-16 21:46:46 PST
Created attachment 452312 [details] Patch
Myles C. Maxfield
Comment 2 2022-02-17 11:50:27 PST
Comment on attachment 452312 [details] Patch I'm not supposed to land this quite yet.
Myles C. Maxfield
Comment 3 2022-02-17 19:34:53 PST
Comment on attachment 452312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review > Source/WTF/wtf/PlatformHave.h:1147 > #if PLATFORM(COCOA) This needs to be #if PLATFORM(COCOA) && !CPU(APPLE_ARMV7K)
Alexey Proskuryakov
Comment 4 2022-02-17 19:39:13 PST
Comment on attachment 452312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review > Source/WebCore/Configurations/WebCore.xcconfig:89 > +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU; Can we actually do this? I didn't think so, because of shared cache.
Myles C. Maxfield
Comment 5 2022-02-17 19:58:12 PST
Comment on attachment 452312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review >> Source/WebCore/Configurations/WebCore.xcconfig:89 >> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU; > > Can we actually do this? I didn't think so, because of shared cache. Why not? It's what ANGLE does directly above.
Alexey Proskuryakov
Comment 6 2022-02-18 12:57:43 PST
Discussed directly, seems fine, but it was worth getting on the same page as to why.
Myles C. Maxfield
Comment 7 2022-02-19 13:00:30 PST
Comment on attachment 452312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review >>> Source/WebCore/Configurations/WebCore.xcconfig:89 >>> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU; >> >> Can we actually do this? I didn't think so, because of shared cache. > > Why not? It's what ANGLE does directly above. Instead of doing weak linking, we can use regular linking, but only do it on the relevant operating systems.
Alexey Proskuryakov
Comment 8 2022-02-19 14:01:03 PST
Except that we apparently do need weak linking on macOS.
Radar WebKit Bug Importer
Comment 9 2022-02-23 21:44:24 PST
<rdar://problem/89398482>
Myles C. Maxfield
Comment 10 2022-03-29 18:17:50 PDT
Comment on attachment 452312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review >> Source/WTF/wtf/PlatformHave.h:1147 >> #if PLATFORM(COCOA) > > This needs to be #if PLATFORM(COCOA) && !CPU(APPLE_ARMV7K) Nevermind. WebGPU doesn't require a 64-bit device. >>>> Source/WebCore/Configurations/WebCore.xcconfig:89 >>>> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU; >>> >>> Can we actually do this? I didn't think so, because of shared cache. >> >> Why not? It's what ANGLE does directly above. > > Instead of doing weak linking, we can use regular linking, but only do it on the relevant operating systems. Weak linking is required because of the base system.
Myles C. Maxfield
Comment 11 2022-03-29 19:47:42 PDT
Created attachment 456087 [details] Patch for committing
EWS
Comment 12 2022-03-30 20:25:42 PDT
Committed r292138 (249045@main): <https://commits.webkit.org/249045@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456087 [details].
Note You need to log in before you can comment on or make changes to this bug.