Bug 236740 - Always use ChildChange::Source::Parser when creating input element UA shadow tree contents
Summary: Always use ChildChange::Source::Parser when creating input element UA shadow ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-16 15:41 PST by Cameron McCormack (:heycam)
Modified: 2022-02-17 16:03 PST (History)
9 users (show)

See Also:


Attachments
Patch (18.11 KB, patch)
2022-02-16 15:43 PST, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-02-16 15:41:48 PST
When creating an input element's UA shadow tree, we currently use a ChildChange::Source value that depends on whether the input element itself was parser- or script-inserted.  But since UA shadow trees are not exposed to content, and we don't have any dependency on the extra work that inserting using ChildChange::Source::API does, we can use ChildChange::Source::Parser unconditionally.

Local testing showed this scored a 0.1% Speedometer 2 improvement.
Comment 1 Cameron McCormack (:heycam) 2022-02-16 15:43:49 PST
Created attachment 452261 [details]
Patch
Comment 2 EWS 2022-02-17 16:02:36 PST
Committed r290086 (247441@main): <https://commits.webkit.org/247441@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452261 [details].
Comment 3 Radar WebKit Bug Importer 2022-02-17 16:03:18 PST
<rdar://problem/89113963>