Bug 236731 - Add support for setting RemoteLayerBackingStore buffers non-volatile in the GPU Process
Summary: Add support for setting RemoteLayerBackingStore buffers non-volatile in the G...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-16 14:20 PST by Simon Fraser (smfr)
Modified: 2022-02-17 09:48 PST (History)
3 users (show)

See Also:

Attachments
Patch (38.51 KB, patch)
2022-02-16 14:26 PST, Simon Fraser (smfr) 		thorton: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (43.16 KB, patch)
2022-02-16 16:55 PST, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (42.24 KB, patch)
2022-02-16 20:40 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-02-16 14:20:05 PST 
Add support for setting RemoteLayerBackingStore buffers non-volatile in the GPU Process
Comment 1 Simon Fraser (smfr) 2022-02-16 14:26:00 PST 
Created attachment 452249 [details]
Patch
Comment 2 Tim Horton 2022-02-16 14:30:55 PST 
Comment on attachment 452249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452249&action=review

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h:49
> +enum class SetNonVolatileResult : uint8_t {

Should this be VolatilityState? (but maybe not, that one only has two states)
Comment 3 Simon Fraser (smfr) 2022-02-16 16:55:57 PST 
Created attachment 452273 [details]
Patch
Comment 4 Simon Fraser (smfr) 2022-02-16 20:40:50 PST 
Created attachment 452301 [details]
Patch
Comment 5 EWS 2022-02-17 09:47:12 PST 
Committed r290030 (247410@main): <https://commits.webkit.org/247410@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452301 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-17 09:48:19 PST 
<rdar://problem/89092676>