Bug 236706 - [EWS] Rename 'patch' to 'change' in transfer-archive-to-s3
Summary: [EWS] Rename 'patch' to 'change' in transfer-archive-to-s3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-16 08:06 PST by Jonathan Bedard
Modified: 2022-02-16 17:36 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-02-16 08:06:20 PST 
transfer-archive-to-s3 works if you pass a hash instead of a patch_id, but we should change the script arguments to make it more clear what we expect the caller to pass.
Comment 1 Radar WebKit Bug Importer 2022-02-16 08:07:05 PST 
<rdar://problem/89025868>
Comment 2 Jonathan Bedard 2022-02-16 08:28:52 PST 
Pull request: https://github.com/WebKit/WebKit/pull/153
Comment 3 Jonathan Bedard 2022-02-16 17:32:30 PST 
Landed https://commits.webkit.org/247372@main (r289986)!
Comment 4 Jonathan Bedard 2022-02-16 17:36:36 PST 
(In reply to Jonathan Bedard from comment #3)
> Landed https://commits.webkit.org/247372@main (r289986)!

It's actually https://commits.webkit.org/247373@main (r289987), fun race condition in `git-webkit land` I'll address tomorrow.