RESOLVED FIXED 236684
GeneratePreferences.rb: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated 
https://bugs.webkit.org/show_bug.cgi?id=236684
Summary GeneratePreferences.rb: warning: Passing safe_level with the 2nd argument of ...
Fujii Hironori
Reported 2022-02-15 18:24:27 PST
Since Ruby 3.1.0, GeneratePreferences.rb reports the following warnings. [5602/6320] Generating ../../WebKit/DerivedSources/WebPageUpdatePreferences.cpp, ../../WebKit/DerivedSources/WebPreferencesDefinitions.h, ../../WebKit/DerivedSources/WebPreferencesExperimentalFeatures.cpp, ../../WebKit/DerivedSources/WebPreferencesGetterSetters.cpp, ../../WebKit/DerivedSources/WebPreferencesInternalDebugFeatures.cpp, ../../WebKit/DerivedSources/WebPreferencesKeys.cpp, ../../WebKit/DerivedSources/WebPreferencesKeys.h, ../../WebKit/DerivedSources/WebPreferencesStoreDefaultsMap.cpp C:/home/webkit/gc/WebKitBuild/Debug/WTF/Scripts/GeneratePreferences.rb:235: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. C:/home/webkit/gc/WebKitBuild/Debug/WTF/Scripts/GeneratePreferences.rb:235: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
Attachments
Patch (1.81 KB, patch)
2022-02-15 18:36 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-02-15 18:36:12 PST
Created attachment 452122 [details] Patch
Yusuke Suzuki
Comment 2 2022-02-17 18:26:05 PST
Comment on attachment 452122 [details] Patch r=me
EWS
Comment 3 2022-02-17 18:47:38 PST
Committed r290104 (247450@main): <https://commits.webkit.org/247450@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452122 [details].
Radar WebKit Bug Importer
Comment 4 2022-02-17 18:48:21 PST
<rdar://problem/89121381>
Fujii Hironori
Comment 5 2022-02-27 12:00:21 PST
*** Bug 237237 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.