Bug 236626 - [css-grid] Absolutely positioned children using 'auto' placement don't cover margin correctly when using RTL
Summary: [css-grid] Absolutely positioned children using 'auto' placement don't cover ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks: 236694
  Show dependency treegraph
 
Reported: 2022-02-14 18:01 PST by Matt Woodrow
Modified: 2022-02-17 10:00 PST (History)
13 users (show)

See Also:


Attachments
Patch (5.47 KB, patch)
2022-02-14 18:05 PST, Matt Woodrow
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-02-14 18:01:48 PST
It looks like our array of column positions is ordered logically (column 0 is the physical right-edge when using RTL), but is always shifted by the physical left border and padding.

When computing the breadth of an abs-pos item that covers the padding area (using 'auto'), we need to account for this, since the auto lines are purely in logical coords.
Comment 1 Matt Woodrow 2022-02-14 18:05:01 PST
Created attachment 451974 [details]
Patch
Comment 2 EWS Watchlist 2022-02-14 18:06:49 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 EWS 2022-02-17 09:59:06 PST
Committed r290032 (247412@main): <https://commits.webkit.org/247412@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451974 [details].
Comment 4 Radar WebKit Bug Importer 2022-02-17 10:00:38 PST
<rdar://problem/89093512>