Bug 236332 - [JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
Summary: [JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-08 14:51 PST by Yusuke Suzuki
Modified: 2022-02-08 17:54 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.33 KB, patch)
2022-02-08 14:52 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (2.36 KB, patch)
2022-02-08 14:55 PST, Yusuke Suzuki 		msaboff: review+
Details | Formatted Diff | Diff
Patch (3.45 KB, patch)
2022-02-08 15:29 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-02-08 14:51:12 PST 
[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
Comment 1 Yusuke Suzuki 2022-02-08 14:52:49 PST 
Created attachment 451308 [details]
Patch
Comment 2 Yusuke Suzuki 2022-02-08 14:54:04 PST 
rdar://88483574
Comment 3 Yusuke Suzuki 2022-02-08 14:55:08 PST 
Created attachment 451309 [details]
Patch
Comment 4 Michael Saboff 2022-02-08 15:01:47 PST 
Comment on attachment 451309 [details]
Patch

r=me
Comment 5 Yusuke Suzuki 2022-02-08 15:29:59 PST 
Created attachment 451314 [details]
Patch
Comment 6 Saam Barati 2022-02-08 15:42:36 PST 
Comment on attachment 451314 [details]
Patch

Can we make the compile assertion you were hitting a RELEASE_ASSERT?
Comment 7 Yusuke Suzuki 2022-02-08 17:01:46 PST 
(In reply to Saam Barati from comment #6)
> Comment on attachment 451314 [details]
> Patch
> 
> Can we make the compile assertion you were hitting a RELEASE_ASSERT?

Discussed with Saam. We should reorganize YarrJITRegisters to avoid this issue.
Comment 8 Yusuke Suzuki 2022-02-08 17:54:36 PST 
Committed r289450 (246994@trunk): <https://commits.webkit.org/246994@trunk>