Bug 236091 - Web Inspector: [Flexbox] Add setting to guard Flexbox Inspector feature
Summary: Web Inspector: [Flexbox] Add setting to guard Flexbox Inspector feature
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
Keywords: InRadar
Depends on:
Blocks: 235647 235820 235924
  Show dependency treegraph
Reported: 2022-02-03 10:35 PST by Nikita Vasilyev
Modified: 2022-02-03 12:34 PST (History)
5 users (show)

See Also:

Patch (2.59 KB, patch)
2022-02-03 10:41 PST, Nikita Vasilyev
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
[Image] With patch applied (31.64 KB, image/png)
2022-02-03 10:42 PST, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2022-02-03 10:35:23 PST
Add an Engineering setting, not Experimental since the feature isn't yet usable for STP users.

Comment 1 Radar WebKit Bug Importer 2022-02-03 10:35:38 PST
Comment 2 Nikita Vasilyev 2022-02-03 10:41:17 PST
Created attachment 450792 [details]
Comment 3 Nikita Vasilyev 2022-02-03 10:42:44 PST
Created attachment 450794 [details]
[Image] With patch applied
Comment 4 Patrick Angle 2022-02-03 10:54:42 PST
Comment on attachment 450792 [details]

r=me, but please open another bugzilla bug blocked on this one to remove the setting particularly since we typically wouldn't add a new setting that isn't being used by the patch it was added in. Please also mark this as a blocker for both your patch and Razvan's patch that will rely on this setting in the coming days.
Comment 5 EWS 2022-02-03 11:47:52 PST
Committed r289064 (246771@main): <https://commits.webkit.org/246771@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450792 [details].