Bug 235871 - [GStreamer] Update flags in internal GStreamer source and sink elements
Summary: [GStreamer] Update flags in internal GStreamer source and sink elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-30 08:02 PST by Philippe Normand
Modified: 2022-02-01 09:21 PST (History)
14 users (show)

See Also:

Attachments
Patch (5.51 KB, patch)
2022-01-30 08:17 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-01-30 08:02:53 PST 
.
Comment 1 Philippe Normand 2022-01-30 08:17:58 PST 
Created attachment 450361 [details]
Patch
Comment 2 Víctor M. Jáquez L. 2022-02-01 01:58:09 PST 
out of curiosity, where is explained this good practice with custom elements based on bins?
Comment 3 Philippe Normand 2022-02-01 08:08:02 PST 
(In reply to Víctor M. Jáquez L. from comment #2)
> out of curiosity, where is explained this good practice with custom elements
> based on bins?

Hm I thought I saw it in the gst-plugins-rs tutorial but that was my imagination it seems :) Most bin-based elements there use this approach though.
Comment 4 EWS 2022-02-01 09:20:14 PST 
Committed r288884 (246636@main): <https://commits.webkit.org/246636@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450361 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-01 09:21:18 PST 
<rdar://problem/88331780>