Bug 235728 - AXIsolatedObject::children should honor the parameter updateChildrenIfNeeded.
Summary: AXIsolatedObject::children should honor the parameter updateChildrenIfNeeded.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-27 13:01 PST by Andres Gonzalez
Modified: 2022-01-27 14:24 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.60 KB, patch)
2022-01-27 13:08 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (2.64 KB, patch)
2022-01-27 13:28 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2022-01-27 13:01:01 PST 
AXIsolatedObject::children should honor the parameter updateChildrenIfNeeded.
Comment 1 Radar WebKit Bug Importer 2022-01-27 13:01:12 PST 
<rdar://problem/88149344>
Comment 2 Andres Gonzalez 2022-01-27 13:08:26 PST 
Created attachment 450169 [details]
Patch
Comment 3 chris fleizach 2022-01-27 13:17:07 PST 
Comment on attachment 450169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450169&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:538
> +const AXCoreObject::AccessibilityChildrenVector& AXIsolatedObject::children(bool  updateChildrenIfNeeded)

too many spaces
"bool updateChildrenIfNeeded"
Comment 4 Andres Gonzalez 2022-01-27 13:28:21 PST 
Created attachment 450170 [details]
Patch
Comment 5 Andres Gonzalez 2022-01-27 13:30:14 PST 
(In reply to chris fleizach from comment #3)
> Comment on attachment 450169 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450169&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:538
> > +const AXCoreObject::AccessibilityChildrenVector& AXIsolatedObject::children(bool  updateChildrenIfNeeded)
> 
> too many spaces
> "bool updateChildrenIfNeeded"

Fixed.
Comment 6 EWS 2022-01-27 14:24:41 PST 
Committed r288703 (246501@main): <https://commits.webkit.org/246501@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450170 [details].