Bug 235427 – [webkitscmpy] Stop killing finished processes

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

show-identifier failed with error "ProcessLookupError: [Errno 3] No such process" in https://build.webkit.org/#/builders/56/builds/8455/steps/4/logs/stdio

Traceback (most recent call last):
  File "Tools/Scripts/git-webkit", line 69, in <module>
    sys.exit(program.main(
  File "/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 134, in main
    return parsed.main(
  File "/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py", line 116, in main
    return Info.main(args, repository=repository, reference=args.argument[0], **kwargs)
  File "/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py", line 56, in main
    commit = repository.find(reference, include_log=args.include_log)
  File "/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py", line 169, in find
    return self.commit(
  File "/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py", line 444, in commit
    self.cache.populate(branch=branch)
  File "/home/buildbot/worker/win10-debug/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py", line 130, in populate
    log.kill()
  File "/usr/lib/python3.8/subprocess.py", line 1943, in kill
    self.send_signal(signal.SIGKILL)
  File "/usr/lib/python3.8/subprocess.py", line 1933, in send_signal
    os.kill(self.pid, sig)
ProcessLookupError: [Errno 3] No such process

[Jonathan Bedard]

Looks like we're failing to check if the process is still running before killing it.

[Radar WebKit Bug Importer]

<rdar://problem/87887233>

[Jonathan Bedard]

Pull-request: https://github.com/WebKit/WebKit/pull/86

[Jonathan Bedard]

246268@main (r288366)