Bug 235381 - Web Inspector: fully blackboxed stack traces don't show the right top call frame
Summary: Web Inspector: fully blackboxed stack traces don't show the right top call frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-19 13:54 PST by Devin Rousso
Modified: 2022-01-20 12:07 PST (History)
5 users (show)

See Also:


Attachments
Patch (19.72 KB, patch)
2022-01-19 13:55 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (19.71 KB, patch)
2022-01-19 16:43 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2022-01-19 13:54:12 PST
# STEPS TO REPRODUCE
1. inspect <http://bogojoker.com/shell/>
2. set a breakpoint on easySlider.min.js:56
3. add an Evaluate JavaScript breakpoint action with the text `console.trace()`
4. blackbox both easySlider.min.js and jquery.js
5. click on either the up arrow or down arrow in the page

# EXPECTED
the Trace in the Console should have "easySlider.min.js:56" (the top call frame) as the location

# ACTUAL
the Trace in the Console has "jquery.js:25:11369" (the bottom call frame) as the location
Comment 1 Devin Rousso 2022-01-19 13:55:39 PST
Created attachment 449515 [details]
Patch
Comment 2 Patrick Angle 2022-01-19 14:10:29 PST
Comment on attachment 449515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449515&action=review

rs=me

> LayoutTests/inspector/debugger/resources/async-stack-trace-test.js:13
>          const topCallFrameIsBoundary = false;
>          const truncated = false;

Nit: These are unused now.
Comment 3 Devin Rousso 2022-01-19 14:32:40 PST
Comment on attachment 449515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449515&action=review

>> LayoutTests/inspector/debugger/resources/async-stack-trace-test.js:13
>>          const truncated = false;
> 
> Nit: These are unused now.

Oops!  Good catch :)
Comment 4 Devin Rousso 2022-01-19 16:43:53 PST
Created attachment 449530 [details]
Patch
Comment 5 EWS 2022-01-19 18:46:30 PST
Committed r288266 (246208@main): <https://commits.webkit.org/246208@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449530 [details].
Comment 6 Radar WebKit Bug Importer 2022-01-20 12:07:59 PST
<rdar://problem/87842848>