Bug 235091 - [Xcode] Configure each project for the legacy build system
Summary: [Xcode] Configure each project for the legacy build system
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-11 18:01 PST by Elliott Williams
Modified: 2022-01-12 15:38 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.87 KB, patch)
2022-01-11 18:19 PST, Elliott Williams 		no flags Details | Formatted Diff | Diff
Patch (11.47 KB, patch)
2022-01-12 13:39 PST, Elliott Williams 		no flags Details | Formatted Diff | Diff
Patch (11.46 KB, patch)
2022-01-12 14:44 PST, Elliott Williams 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-01-11 18:01:03 PST 
[Xcode] Configure each project for the legacy build system
Comment 1 Radar WebKit Bug Importer 2022-01-11 18:01:18 PST 
<rdar://problem/87429937>
Comment 2 Elliott Williams 2022-01-11 18:02:34 PST 
rdar://87429448
Comment 3 Elliott Williams 2022-01-11 18:19:01 PST 
Created attachment 448898 [details]
Patch
Comment 4 Alexey Proskuryakov 2022-01-12 09:28:03 PST 
This is not up for review yet, but looks good to me. EWS test failures are presumably unrelated?
Comment 5 Elliott Williams 2022-01-12 11:32:51 PST 
(In reply to Alexey Proskuryakov from comment #4)
> This is not up for review yet, but looks good to me. EWS test failures are
> presumably unrelated?

Yep, I was waiting for EWS results and it looks reasonable. Marked r?
Comment 6 EWS 2022-01-12 12:20:44 PST 
Unable to find any modified ChangeLog in Attachment 448898 [details]
Comment 7 Elliott Williams 2022-01-12 13:39:29 PST 
Created attachment 448991 [details]
Patch

Missed uploading changelog entries, sorry about that.
Comment 8 Elliott Williams 2022-01-12 14:44:33 PST 
Created attachment 448998 [details]
Patch
Comment 9 EWS 2022-01-12 15:38:10 PST 
Committed r287956 (245985@main): <https://commits.webkit.org/245985@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448998 [details].