Bug 235083 - [cocoa] Allow TestWebKitAPI::HTTPServer to run non-loopback addresses for API tests
Summary: [cocoa] Allow TestWebKitAPI::HTTPServer to run non-loopback addresses for API...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-11 14:27 PST by Frédéric Wang (:fredw)
Modified: 2022-01-12 00:19 PST (History)
1 user (show)

See Also:


Attachments
Patch (13.92 KB, patch)
2022-01-11 14:29 PST, Frédéric Wang (:fredw)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2022-01-11 14:27:19 PST
Currently TestWebKitAPI::HTTPServer only allows to use 127.0.0.1 or localhost as host names.
Comment 1 Frédéric Wang (:fredw) 2022-01-11 14:29:20 PST
Created attachment 448879 [details]
Patch
Comment 2 Alexey Proskuryakov 2022-01-11 18:47:01 PST
I don’t think that this should be possible. Exposing test code over network (even local) is a security problem, and we are explicitly preventing that in tests.
Comment 3 Frédéric Wang (:fredw) 2022-01-12 00:19:32 PST
Using this hardcoded 192.168.0.10 IP address seems to work on my local machine, but the requests time out on the api bots.

(In reply to Alexey Proskuryakov from comment #2)
> I don’t think that this should be possible. Exposing test code over network
> (even local) is a security problem, and we are explicitly preventing that in
> tests.

Makes sense. Let's close as WONTFIX then.