Bug 235034 – Use the new template ColorSpaceCG helpers to cleanup some code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Use the new template ColoreSpaceCG helpers to cleanup some code

[Sam Weinig]

Created attachment 448778 [details]
Patch

[Sam Weinig]

Created attachment 448781 [details]
Patch

[Sam Weinig]

Created attachment 448805 [details]
Patch

[Cameron McCormack (:heycam)]

Comment on attachment 448805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448805&action=review

> Source/WebCore/platform/graphics/cg/GradientRendererCG.cpp:511
> +    using OutputSpaceColorType = std::conditional_t<HasCGColorSpaceMapping<ColorSpace::ExtendedSRGB>, ExtendedSRGBA<float>, SRGBA<float>>;

Since this declaration to choose "ExtendedSRGB if supported else SRGB" is used in a bunch of places, maybe it should be in CGColorSpace.h? Maybe a templated using statement (so float is still specified explicitly)?

[Sam Weinig]

(In reply to Cameron McCormack (:heycam) from comment #4)
> Comment on attachment 448805 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448805&action=review
> 
> > Source/WebCore/platform/graphics/cg/GradientRendererCG.cpp:511
> > +    using OutputSpaceColorType = std::conditional_t<HasCGColorSpaceMapping<ColorSpace::ExtendedSRGB>, ExtendedSRGBA<float>, SRGBA<float>>;
> 
> Since this declaration to choose "ExtendedSRGB if supported else SRGB" is
> used in a bunch of places, maybe it should be in CGColorSpace.h? Maybe a
> templated using statement (so float is still specified explicitly)?

Sounds like a good idea.

[EWS]

Committed r287889 (245928@main): <https://commits.webkit.org/245928@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448805 [details].

[Radar WebKit Bug Importer]

<rdar://problem/87408048>