Bug 234937 - Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters (v2)
Summary: Ensure that the scrolling thread always commits layer position changes to red...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-06 13:59 PST by Simon Fraser (smfr)
Modified: 2022-01-06 20:58 PST (History)
9 users (show)

See Also:

Attachments
Patch (20.19 KB, patch)
2022-01-06 14:10 PST, Simon Fraser (smfr) 		thorton: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (20.09 KB, patch)
2022-01-06 15:46 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-01-06 13:59:27 PST 
Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters (v2)
Comment 1 Simon Fraser (smfr) 2022-01-06 14:10:59 PST 
Created attachment 448536 [details]
Patch
Comment 2 Tim Horton 2022-01-06 14:36:06 PST 
Comment on attachment 448536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448536&action=review

> Source/WebCore/ChangeLog:8
> +        Refine the logic added in r286932, which tries ensure that the scrolling thread commits a

"tries ensure"

> Source/WebCore/page/Page.h:617
> +    void scheduledRenderingUpdate();

"didSchedule"? (initially I didn't notice the -ed and thought this was a parameterless version of the line above)
Comment 3 Simon Fraser (smfr) 2022-01-06 15:46:24 PST 
Created attachment 448542 [details]
Patch
Comment 4 EWS 2022-01-06 20:57:50 PST 
Committed r287739 (245809@main): <https://commits.webkit.org/245809@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448542 [details].
Comment 5 Radar WebKit Bug Importer 2022-01-06 20:58:52 PST 
<rdar://problem/87233606>