Bug 234908 – REGRESSION (r287323): [iOS] 9 imported/w3c/web-platform-tests/css/css-transforms tests consistently failing

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ryan Haddad]

The following tests have been consistently failing on iOS bots as of https://trac.webkit.org/changeset/287323/webkit with 0.01-0.04% image diffs

  imported/w3c/web-platform-tests/css/css-transforms/2d-rotate-001.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/css-skew-002.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/rotate_45deg.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/rotate_x_45deg.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/rotate_y_45deg.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/skew-test1.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/transform-percent-008.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/ttwf-transform-skewx-001.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/ttwf-transform-skewy-001.html [ ImageOnlyFailure ]


https://ews-build.s3-us-west-2.amazonaws.com/iOS-15-Simulator-WK2-Tests-EWS/r448393-5020-rerun/results.html

https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2F2d-rotate-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Fcss-skew-002.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Frotate_45deg.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Frotate_x_45deg.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Frotate_y_45deg.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Fskew-test1.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Ftransform-percent-008.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Fttwf-transform-skewx-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Fttwf-transform-skewy-001.html

[Radar WebKit Bug Importer]

<rdar://problem/87172770>

[Ryan Haddad]

The diffs appear to be related to the edges of the shapes.

[Ryan Haddad]

Actually, some of these were newly passing with r287323 but started failing with r287345

[Simon Fraser (smfr)]

Yay boo.

[Simon Fraser (smfr)]

We need to adjust the pixel tolerance and do a WPT PR.

[Martin Robinson]

Created attachment 448489 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Martin Robinson]

The differences all look pretty reasonable to me. I've uploaded a patch updating them as well as a corresponding WPT PR on Github.

[Simon Fraser (smfr)]

Comment on attachment 448489 [details]
Patch

Thanks Martin!

[EWS]

Committed r287688 (245784@main): <https://commits.webkit.org/245784@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448489 [details].