Bug 234908 - REGRESSION (r287323): [iOS] 9 imported/w3c/web-platform-tests/css/css-transforms tests consistently failing
Summary: REGRESSION (r287323): [iOS] 9 imported/w3c/web-platform-tests/css/css-transfo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-05 17:04 PST by Ryan Haddad
Modified: 2022-01-06 08:41 PST (History)
7 users (show)

See Also:

Attachments
Patch (10.25 KB, patch)
2022-01-06 05:36 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2022-01-05 17:04:42 PST 
The following tests have been consistently failing on iOS bots as of https://trac.webkit.org/changeset/287323/webkit with 0.01-0.04% image diffs

  imported/w3c/web-platform-tests/css/css-transforms/2d-rotate-001.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/css-skew-002.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/rotate_45deg.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/rotate_x_45deg.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/rotate_y_45deg.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/skew-test1.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/transform-percent-008.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/ttwf-transform-skewx-001.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-transforms/ttwf-transform-skewy-001.html [ ImageOnlyFailure ]


https://ews-build.s3-us-west-2.amazonaws.com/iOS-15-Simulator-WK2-Tests-EWS/r448393-5020-rerun/results.html

https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2F2d-rotate-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Fcss-skew-002.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Frotate_45deg.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Frotate_x_45deg.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Frotate_y_45deg.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Fskew-test1.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Ftransform-percent-008.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Fttwf-transform-skewx-001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-transforms%2Fttwf-transform-skewy-001.html
Comment 1 Radar WebKit Bug Importer 2022-01-05 17:05:01 PST 
<rdar://problem/87172770>
Comment 2 Ryan Haddad 2022-01-05 17:13:46 PST 
The diffs appear to be related to the edges of the shapes.
Comment 3 Ryan Haddad 2022-01-05 17:20:59 PST 
Actually, some of these were newly passing with r287323 but started failing with r287345
Comment 4 Simon Fraser (smfr) 2022-01-05 20:09:46 PST 
Yay boo.
Comment 5 Simon Fraser (smfr) 2022-01-05 20:12:50 PST 
We need to adjust the pixel tolerance and do a WPT PR.
Comment 6 Martin Robinson 2022-01-06 05:36:38 PST 
Created attachment 448489 [details]
Patch
Comment 7 EWS Watchlist 2022-01-06 05:37:40 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 8 Martin Robinson 2022-01-06 06:07:44 PST 
The differences all look pretty reasonable to me. I've uploaded a patch updating them as well as a corresponding WPT PR on Github.
Comment 9 Simon Fraser (smfr) 2022-01-06 08:15:47 PST 
Comment on attachment 448489 [details]
Patch

Thanks Martin!
Comment 10 EWS 2022-01-06 08:41:48 PST 
Committed r287688 (245784@main): <https://commits.webkit.org/245784@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448489 [details].