Bug 234864 - Rename Vector and FixedVector::findMatching to findIf to match stl naming.
Summary: Rename Vector and FixedVector::findMatching to findIf to match stl naming.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on: 234855
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-04 16:08 PST by Mark Lam
Modified: 2022-01-24 22:16 PST (History)
49 users (show)

See Also:

Attachments
work in progress. (114.85 KB, patch)
2022-01-04 17:28 PST, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
work in progress. (112.60 KB, patch)
2022-01-04 17:42 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (123.37 KB, patch)
2022-01-24 13:58 PST, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing. (123.50 KB, patch)
2022-01-24 14:05 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Mark Lam 2022-01-04 17:16:30 PST 
Also do reverseFindMatching.
Comment 2 Mark Lam 2022-01-04 17:28:22 PST 
Created attachment 448352 [details]
work in progress.
Comment 3 EWS Watchlist 2022-01-04 17:29:15 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Mark Lam 2022-01-04 17:42:22 PST 
Created attachment 448354 [details]
work in progress.
Comment 5 Radar WebKit Bug Importer 2022-01-11 16:09:18 PST 
<rdar://problem/87424746>
Comment 6 Mark Lam 2022-01-24 13:58:07 PST 
Created attachment 449854 [details]
proposed patch.
Comment 7 Yusuke Suzuki 2022-01-24 14:00:01 PST 
Comment on attachment 449854 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=449854&action=review

r=me

> Tools/TestWebKitAPI/Tests/WTF/FixedVector.cpp:160
>  TEST(WTF_FixedVector, FindMatching)

Rename this test to FindIf.
Comment 8 Mark Lam 2022-01-24 14:05:13 PST 
Created attachment 449855 [details]
patch for landing.

Thanks for the review.
Comment 9 EWS 2022-01-24 22:16:43 PST 
Committed r288541 (246373@main): <https://commits.webkit.org/246373@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449855 [details].