RESOLVED FIXED 234864
Rename Vector and FixedVector::findMatching to findIf to match stl naming. 
https://bugs.webkit.org/show_bug.cgi?id=234864
Summary Rename Vector and FixedVector::findMatching to findIf to match stl naming.
Attachments
work in progress. (114.85 KB, patch)
2022-01-04 17:28 PST, Mark Lam 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
work in progress. (112.60 KB, patch)
2022-01-04 17:42 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (123.37 KB, patch)
2022-01-24 13:58 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
patch for landing. (123.50 KB, patch)
2022-01-24 14:05 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2022-01-04 17:16:30 PST
Also do reverseFindMatching.
Mark Lam
Comment 2 2022-01-04 17:28:22 PST
Created attachment 448352 [details] work in progress.
EWS Watchlist
Comment 3 2022-01-04 17:29:15 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Mark Lam
Comment 4 2022-01-04 17:42:22 PST
Created attachment 448354 [details] work in progress.
Radar WebKit Bug Importer
Comment 5 2022-01-11 16:09:18 PST
<rdar://problem/87424746>
Mark Lam
Comment 6 2022-01-24 13:58:07 PST
Created attachment 449854 [details] proposed patch.
Yusuke Suzuki
Comment 7 2022-01-24 14:00:01 PST
Comment on attachment 449854 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=449854&action=review r=me > Tools/TestWebKitAPI/Tests/WTF/FixedVector.cpp:160 > TEST(WTF_FixedVector, FindMatching) Rename this test to FindIf.
Mark Lam
Comment 8 2022-01-24 14:05:13 PST
Created attachment 449855 [details] patch for landing. Thanks for the review.
EWS
Comment 9 2022-01-24 22:16:43 PST
Committed r288541 (246373@main): <https://commits.webkit.org/246373@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449855 [details].
Note You need to log in before you can comment on or make changes to this bug.