Bug 234849 - Remove the `PreferInlineTextSelectionInImages` internal feature flag
Summary: Remove the `PreferInlineTextSelectionInImages` internal feature flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-04 09:33 PST by Wenson Hsieh
Modified: 2022-04-23 22:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (44.55 KB, patch)
2022-04-23 16:49 PDT, Wenson Hsieh 		sam: review+
Details | Formatted Diff | Diff
For landing (30.87 KB, patch)
2022-04-23 17:41 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For landing (44.53 KB, patch)
2022-04-23 18:11 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-01-04 09:33:00 PST 
This was introduced in r279164 as a mitigation against the power use implications of inline text selection with Live Text on non-ANE Macs.
Comment 1 Radar WebKit Bug Importer 2022-01-11 09:33:16 PST 
<rdar://problem/87403606>
Comment 2 Wenson Hsieh 2022-02-28 17:18:07 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2022-04-23 15:49:15 PDT 
...back to being no longer used by any platform.
Comment 4 Wenson Hsieh 2022-04-23 16:49:58 PDT 
Created attachment 458224 [details]
Patch
Comment 5 Wenson Hsieh 2022-04-23 17:33:54 PDT 
Comment on attachment 458224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458224&action=review

Thanks for the review!

> Source/WebKit/ChangeLog:14
> +        ultimately deemed unnecessary in macOS 15.

(Oops — I clearly meant macOS 12 here!)
Comment 6 Wenson Hsieh 2022-04-23 17:41:33 PDT 
Created attachment 458225 [details]
For landing
Comment 7 Wenson Hsieh 2022-04-23 18:11:45 PDT 
Created attachment 458226 [details]
For landing
Comment 8 EWS 2022-04-23 20:47:01 PDT 
Committed r293299 (249924@main): <https://commits.webkit.org/249924@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458226 [details].