WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
234849
Remove the `PreferInlineTextSelectionInImages` internal feature flag
https://bugs.webkit.org/show_bug.cgi?id=234849
Summary
Remove the `PreferInlineTextSelectionInImages` internal feature flag
Wenson Hsieh
Reported
2022-01-04 09:33:00 PST
This was introduced in
r279164
as a mitigation against the power use implications of inline text selection with Live Text on non-ANE Macs.
Attachments
Patch
(44.55 KB, patch)
2022-04-23 16:49 PDT
,
Wenson Hsieh
sam
: review+
Details
Formatted Diff
Diff
For landing
(30.87 KB, patch)
2022-04-23 17:41 PDT
,
Wenson Hsieh
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
For landing
(44.53 KB, patch)
2022-04-23 18:11 PDT
,
Wenson Hsieh
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-01-11 09:33:16 PST
<
rdar://problem/87403606
>
Wenson Hsieh
Comment 2
2022-02-28 17:18:07 PST
Comment hidden (obsolete)
Not to be fixed, since this is now used by at least one platform.
Wenson Hsieh
Comment 3
2022-04-23 15:49:15 PDT
...back to being no longer used by any platform.
Wenson Hsieh
Comment 4
2022-04-23 16:49:58 PDT
Created
attachment 458224
[details]
Patch
Wenson Hsieh
Comment 5
2022-04-23 17:33:54 PDT
Comment on
attachment 458224
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=458224&action=review
Thanks for the review!
> Source/WebKit/ChangeLog:14 > + ultimately deemed unnecessary in macOS 15.
(Oops — I clearly meant macOS 12 here!)
Wenson Hsieh
Comment 6
2022-04-23 17:41:33 PDT
Created
attachment 458225
[details]
For landing
Wenson Hsieh
Comment 7
2022-04-23 18:11:45 PDT
Created
attachment 458226
[details]
For landing
EWS
Comment 8
2022-04-23 20:47:01 PDT
Committed
r293299
(
249924@main
): <
https://commits.webkit.org/249924@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 458226
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug