Bug 234523 - Roll ANGLE to aabfe8747d 12-17-2021
Summary: Roll ANGLE to aabfe8747d 12-17-2021
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
Keywords: InRadar
Depends on:
Blocks: 234391
  Show dependency treegraph
Reported: 2021-12-20 12:46 PST by Kyle Piddington
Modified: 2022-01-05 14:00 PST (History)
10 users (show)

See Also:

Patch (1.10 MB, patch)
2021-12-20 12:47 PST, Kyle Piddington
no flags Details | Formatted Diff | Diff
Patch (1.09 MB, patch)
2022-01-04 11:27 PST, Kyle Piddington
no flags Details | Formatted Diff | Diff
Patch for landing (1.09 MB, patch)
2022-01-05 11:13 PST, Kyle Piddington
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-12-20 12:46:27 PST
Roll ANGLE to aabfe8747d 12-17-2021
Comment 1 Kyle Piddington 2021-12-20 12:47:44 PST
Created attachment 447623 [details]
Comment 2 EWS Watchlist 2021-12-20 12:51:02 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-12-20 13:04:26 PST
Comment on attachment 447623 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=447623&action=review

Great to see the progress reducing the diffs from upstream. r+ from me; most carefully reviewed the Metal backend changes, and changes.diff. A couple of small questions; feel free to move ahead without re-review.

> Source/ThirdParty/ANGLE/ChangeLog:8
> +        * ANGLE.plist:

Suggest trimming ChangeLog as before.

> Source/ThirdParty/ANGLE/changes.diff:922
> +     switch_data += "#if (TARGET_OS_OSX && (__MAC_OS_X_VERSION_MAX_ALLOWED >= 110000))\n"

Could you double-check whether these ifdefs were properly upstreamed? Thought these diffs should have been resolved already.
Comment 4 Radar WebKit Bug Importer 2021-12-27 12:47:15 PST
Comment 5 Kyle Piddington 2022-01-04 11:27:38 PST
Created attachment 448311 [details]
Comment 6 Kenneth Russell 2022-01-04 17:55:56 PST
Comment on attachment 448311 [details]

Looks good to me - r+.

I most carefully reviewed changes.diff and all the changes under src/libANGLE/renderer/metal.
Comment 7 Kyle Piddington 2022-01-05 11:13:18 PST
Created attachment 448411 [details]
Patch for landing
Comment 8 EWS 2022-01-05 14:00:06 PST
Committed r287652 (245750@main): <https://commits.webkit.org/245750@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448411 [details].