Bug 234517 - [LFC][IFC] Move display builder files under /display directory
Summary: [LFC][IFC] Move display builder files under /display directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-20 10:09 PST by zalan
Modified: 2021-12-20 12:19 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.65 KB, patch)
2021-12-20 10:24 PST, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (85.36 KB, patch)
2021-12-20 11:04 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-12-20 10:09:57 PST 
ssia
Comment 1 zalan 2021-12-20 10:24:48 PST 
Created attachment 447610 [details]
Patch
Comment 2 zalan 2021-12-20 11:04:10 PST 
Created attachment 447612 [details]
Patch
Comment 3 Antti Koivisto 2021-12-20 11:56:59 PST 
Comment on attachment 447612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447612&action=review

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:42
> +namespace WebCore {
> +namespace Layout {

Are you going to switch the namespace too?
Comment 4 zalan 2021-12-20 12:11:50 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 447612 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447612&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:42
> > +namespace WebCore {
> > +namespace Layout {
> 
> Are you going to switch the namespace too?
Yeah, I should do that too at some point.
Comment 5 EWS 2021-12-20 12:18:25 PST 
Committed r287271 (245427@main): <https://commits.webkit.org/245427@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447612 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-20 12:19:19 PST 
<rdar://problem/86735343>