Bug 234312 - null ptr deref in WebCore::ApplyStyleCommand::applyRelativeFontStyleChange
Summary: null ptr deref in WebCore::ApplyStyleCommand::applyRelativeFontStyleChange
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gabriel Nava Marino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-14 13:53 PST by Gabriel Nava Marino
Modified: 2021-12-15 16:57 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.20 KB, patch)
2021-12-14 14:13 PST, Gabriel Nava Marino
no flags Details | Formatted Diff | Diff
Patch (7.91 KB, patch)
2021-12-14 15:57 PST, Gabriel Nava Marino
no flags Details | Formatted Diff | Diff
Patch (7.91 KB, patch)
2021-12-15 13:55 PST, Gabriel Nava Marino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Nava Marino 2021-12-14 13:53:57 PST
Given the test case, nodeFullySelected can result in a disconnected node.
Comment 1 Gabriel Nava Marino 2021-12-14 14:13:35 PST
Created attachment 447159 [details]
Patch
Comment 2 Gabriel Nava Marino 2021-12-14 14:34:48 PST
<rdar://problem/85599563>
Comment 3 Gabriel Nava Marino 2021-12-14 15:57:15 PST
Created attachment 447171 [details]
Patch
Comment 4 Chris Dumez 2021-12-15 11:12:19 PST
Comment on attachment 447171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447171&action=review

> Source/WebCore/ChangeLog:12
> +        the possibliity of this scenario.

typo: possibliity
Comment 5 Gabriel Nava Marino 2021-12-15 13:55:48 PST
Created attachment 447283 [details]
Patch
Comment 6 EWS 2021-12-15 16:57:13 PST
Committed r287118 (245302@main): <https://commits.webkit.org/245302@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447283 [details].