Bug 234181 – REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Truitt Savell]

It looks like after the changes in https://trac.webkit.org/changeset/286841/webkit many webrtc tests began timing out or failing, both constantly and flakily on iOS

Results:
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/r286852%20(696)/results.html

Build:
https://build.webkit.org/#/builders/268/builds/696

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webrtc%2Fcertificates-indexeddb.html&test=webrtc%2Fdatachannel%2Fmultiple-connections.html&test=webrtc%2Fmsection-recycling.html&test=webrtc%2Fpeer-connection-audio-unmute.html&test=webrtc%2Fpeer-connection-remote-audio-mute.html&test=webrtc%2Fpeerconnection-page-cache-long.html&test=webrtc%2Freceiver-track-should-stay-live-even-if-receiver-is-inactive.html&test=webrtc%2Fremove-track.html&test=webrtc%2Fvideo-interruption.html&test=webrtc%2Fvideo-mute.html&test=webrtc%2Fvideo-rotation-no-cvo.html&test=webrtc%2Fvideo-stats.html&test=webrtc%2Fvp9.html

[Radar WebKit Bug Importer]

<rdar://problem/86343642>

[youenn fablet]

Created attachment 446886 [details]
Patch

[youenn fablet]

Created attachment 446890 [details]
Patch

[Eric Carlson]

Comment on attachment 446890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446890&action=review

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:308
> +            RELEASE_LOG_ERROR(WebRTC, "NetworkRTCUDPSocketCocoaConnections failed processing UDP data with error %d", nw_error_get_error_code(error));

Nit: if you log `errorCode` you won't have to call nw_error_get_error_code() again

[youenn fablet]

Created attachment 447010 [details]
Patch for landing

[EWS]

Committed r286961 (245184@main): <https://commits.webkit.org/245184@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447010 [details].