Bug 234181 - REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on iOS
Summary: REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-10 15:37 PST by Truitt Savell
Modified: 2021-12-13 11:53 PST (History)
5 users (show)

See Also:


Attachments
Patch (13.11 KB, patch)
2021-12-11 08:04 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (13.11 KB, patch)
2021-12-11 08:56 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (13.04 KB, patch)
2021-12-13 09:00 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2021-12-10 15:38:09 PST
<rdar://problem/86343642>
Comment 2 youenn fablet 2021-12-11 08:04:09 PST
Created attachment 446886 [details]
Patch
Comment 3 youenn fablet 2021-12-11 08:56:30 PST
Created attachment 446890 [details]
Patch
Comment 4 Eric Carlson 2021-12-13 08:42:55 PST
Comment on attachment 446890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446890&action=review

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:308
> +            RELEASE_LOG_ERROR(WebRTC, "NetworkRTCUDPSocketCocoaConnections failed processing UDP data with error %d", nw_error_get_error_code(error));

Nit: if you log `errorCode` you won't have to call nw_error_get_error_code() again
Comment 5 youenn fablet 2021-12-13 09:00:19 PST
Created attachment 447010 [details]
Patch for landing
Comment 6 EWS 2021-12-13 11:53:18 PST
Committed r286961 (245184@main): <https://commits.webkit.org/245184@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447010 [details].