Bug 234164 - ASTC-HDR is unavailable on some platforms
Summary: ASTC-HDR is unavailable on some platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-10 11:52 PST by Kyle Piddington
Modified: 2021-12-10 19:27 PST (History)
8 users (show)

See Also:

Attachments
Patch (38.27 KB, patch)
2021-12-10 11:53 PST, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (39.96 KB, patch)
2021-12-10 14:38 PST, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (41.44 KB, patch)
2021-12-10 16:23 PST, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (41.53 KB, patch)
2021-12-10 16:39 PST, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch for landing (41.55 KB, patch)
2021-12-10 18:03 PST, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-12-10 11:52:13 PST 
ASTC-HDR is unavailable on TVOS
Comment 1 Kyle Piddington 2021-12-10 11:53:03 PST 
Created attachment 446775 [details]
Patch
Comment 2 EWS Watchlist 2021-12-10 11:53:47 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-12-10 12:01:46 PST 
Comment on attachment 446775 [details]
Patch

How urgently does this fix need to make it into WebKit?

It would be better in the long run if this patch were reviewed upstream in ANGLE and then the update-angle script were run in WebKit to pull it in.
Comment 4 Kenneth Russell 2021-12-10 12:25:07 PST 
Comment on attachment 446775 [details]
Patch

Kyle and I chatted on Slack and it's clear this is urgent, so r+ and let's upstream it later.
Comment 5 Kyle Piddington 2021-12-10 14:38:55 PST 
Created attachment 446818 [details]
Patch
Comment 6 Kyle Piddington 2021-12-10 16:23:18 PST 
Created attachment 446841 [details]
Patch
Comment 7 Kyle Piddington 2021-12-10 16:39:08 PST 
Created attachment 446846 [details]
Patch
Comment 8 Kenneth Russell 2021-12-10 17:47:26 PST 
Comment on attachment 446846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446846&action=review

> Source/ThirdParty/ANGLE/ChangeLog:6
> +	Update autogenerated format table to avoid using ASTC_HDR on

The ChangeLog formatting is strange - suggest you revisit this and match the other entries.
Comment 9 Kyle Piddington 2021-12-10 18:03:51 PST 
Created attachment 446852 [details]
Patch for landing
Comment 10 EWS 2021-12-10 19:26:02 PST 
Committed r286899 (245127@main): <https://commits.webkit.org/245127@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446852 [details].
Comment 11 Radar WebKit Bug Importer 2021-12-10 19:27:19 PST 
<rdar://problem/86350864>