Bug 234108 - [GPU Process] [Filters] Make FilterEffectVector a Vector of Ref<FilterEffect>
Summary: [GPU Process] [Filters] Make FilterEffectVector a Vector of Ref<FilterEffect>
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
Keywords: InRadar
Depends on:
Blocks: 231253
  Show dependency treegraph
Reported: 2021-12-09 15:39 PST by Said Abou-Hallawa
Modified: 2021-12-10 11:28 PST (History)
16 users (show)

See Also:

Patch (21.24 KB, patch)
2021-12-09 23:02 PST, Said Abou-Hallawa
heycam: review+
Details | Formatted Diff | Diff
Patch (24.72 KB, patch)
2021-12-10 00:56 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-12-09 15:39:43 PST
There is no case that would require inserting a nullptr in FilterEffectVector.
Comment 1 Said Abou-Hallawa 2021-12-09 23:02:37 PST
Created attachment 446667 [details]
Comment 2 Cameron McCormack (:heycam) 2021-12-09 23:50:02 PST
Comment on attachment 446667 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=446667&action=review

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:150
>  FilterEffect* FilterEffect::inputEffect(unsigned number) const

Should this be changed to return a reference too?
Comment 3 Said Abou-Hallawa 2021-12-10 00:56:11 PST
Created attachment 446677 [details]
Comment 4 EWS 2021-12-10 11:27:54 PST
Committed r286864 (245095@main): <https://commits.webkit.org/245095@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446677 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-10 11:28:31 PST